MCP server for accessing SAP ERP system data, specifically sales orders through the SAP ES5 demo system OData API
Single tool with minimal quality across naming, description, and schema dimensions. The tool name 'get_salesorders_list' follows verb_noun convention but lacks clarity on data source or filtering. Description is extremely sparse (10 words, well below 194-char baseline). Input schema exists but is incomplete, lacks descriptions for the 'top' parameter and provides no output schema documentation. No error handling guidance, no pagination details despite accepting a 'top' parameter that suggests list results. Code shows defensive error handling (try-catch returning None) but no actionable error messages to guide LLM recovery.
Get a list of sales orders.
Tool description is critically sparse: 'Get a list of sales orders.' (10 words), far below 194-char baseline. LLMs cannot determine WHEN to use this tool vs alternatives, what the return structure is, or how pagination works.
Input parameter 'top' lacks description. The parameter name alone does not convey: Is this a limit? An offset? Does it default? What's the valid range? LLMs will guess.
No output schema documented. Code returns `response.json()` directly from SAP API or `{"error": "Failed to fetch sales orders."}` on failure. LLMs cannot plan downstream operations without knowing field names, types, or structure.
No pagination guidance or limits enforcement. Tool accepts 'top' parameter but does not document: Is there a maximum? Are results capped at 20/50/100? What if 'top' is 10000? The SAP endpoint uses OData $top parameter, should clarify limits and expose $skip/$filter if relevant.
| Scored | Grade | Overall | Spec posture | Rubric |
|---|---|---|---|---|
| 2026-09-22 | F | 7 | 2026-07-28+ | v2 |
| 2026-03-09 | F | 32 | - | v1 |
Error handling returns bare `{"error": "Failed to fetch sales orders."}` on network/API failure. This tells the LLM nothing: Is it retryable? Should the user be asked? Is SAP down? No recovery guidance.
SAP credentials (headers dict) are empty in source code. Real deployment would require Basic Auth or OAuth token. If stored in environment, document this in tool description. If passed as parameter, this is a security violation (secrets in params leak to logs).
No validation of 'top' parameter. Code accepts any integer and passes directly to URL. Negative, zero, or absurdly large values (e.g. 999999) could break the SAP API or timeout. Should validate range (e.g., 1 - 1000) and return clear error.